Skip to content

content-access-mode-all option appears to be no longer needed or supported - #20831

Merged
ogajduse merged 1 commit into
SatelliteQE:masterfrom
jnagare-redhat:fix_content_access_mode
Feb 21, 2026
Merged

content-access-mode-all option appears to be no longer needed or supported#20831
ogajduse merged 1 commit into
SatelliteQE:masterfrom
jnagare-redhat:fix_content_access_mode

Conversation

@jnagare-redhat

@jnagare-redhat jnagare-redhat commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Problem Statement

--content-access-mode-all option not recognized in Satellite stream-166
SCA (Simple Content Access) is now the default mode, making this option obsolete

Solution

Removed the content-access-mode-all parameter from the ActivationKey.product_content() call

Related Issues

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_hostcollection.py -k "test_positive_install_errata or test_positive_change_assigned_content or test_positive_install_package"

Summary by Sourcery

Bug Fixes:

  • Stop passing an unsupported content-access-mode-all parameter when fetching activation key product content to avoid errors on newer Satellite streams.

@jnagare-redhat
jnagare-redhat requested a review from a team as a code owner February 20, 2026 08:42
@jnagare-redhat jnagare-redhat added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Feb 20, 2026
@sourcery-ai

sourcery-ai Bot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the obsolete 'content-access-mode-all' parameter from activation key product content retrieval to align with current Satellite behavior where Simple Content Access is the default.

Sequence diagram for activation key product content override without content-access-mode-all

sequenceDiagram
    participant HostHelper as HostRepositoryMixin
    participant ActivationKeyCLI as ActivationKey

    HostHelper->>ActivationKeyCLI: product_content(id)
    loop for each repo in product_content
        HostHelper->>ActivationKeyCLI: content_override(activation_key_id, content_label, override)
    end
Loading

Class diagram for HostRepositoryMixin and ActivationKey CLI after removing content-access-mode-all

classDiagram
    class HostRepositoryMixin {
        +setup_activation_key(organization, lifecycle_environment, content_view, content, host_collection, override)
    }

    class ActivationKey {
        +product_content(id)
        +content_override(activation_key_id, content_label, override)
    }

    HostRepositoryMixin ..> ActivationKey : uses
Loading

File-Level Changes

Change Details Files
Stop passing the deprecated content-access-mode-all flag when fetching activation key product content before applying content overrides.
  • Update setup_activation_key helper to call ActivationKey.product_content with only the activation key id.
  • Ensure activation key content overrides are now computed based on the default content access mode behavior rather than forcing content-access-mode-all.
robottelo/host_helpers/repository_mixins.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider grepping the codebase for other uses of content-access-mode-all or related flags to ensure there are no remaining assumptions about that option elsewhere.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider grepping the codebase for other uses of `content-access-mode-all` or related flags to ensure there are no remaining assumptions about that option elsewhere.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jnagare-redhat

Copy link
Copy Markdown
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_hostcollection.py -k "test_positive_install_errata or test_positive_change_assigned_content or test_positive_install_package"

@jnagare-redhat jnagare-redhat added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 20, 2026
@chris1984 chris1984 added the Tier 1 ACK A Tier 1 reviewer has ACK'd this PR label Feb 21, 2026
@ogajduse
ogajduse merged commit c0fb0e5 into SatelliteQE:master Feb 21, 2026
13 checks passed
rmynar pushed a commit to rmynar/robottelo that referenced this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master Tier 1 ACK A Tier 1 reviewer has ACK'd this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants