content-access-mode-all option appears to be no longer needed or supported - #20831
Merged
ogajduse merged 1 commit intoFeb 21, 2026
Merged
Conversation
jnagare-redhat
requested review from
ColeHiggins2,
LadislavVasina1,
synkd and
vijaysawant
February 20, 2026 08:42
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the obsolete 'content-access-mode-all' parameter from activation key product content retrieval to align with current Satellite behavior where Simple Content Access is the default. Sequence diagram for activation key product content override without content-access-mode-allsequenceDiagram
participant HostHelper as HostRepositoryMixin
participant ActivationKeyCLI as ActivationKey
HostHelper->>ActivationKeyCLI: product_content(id)
loop for each repo in product_content
HostHelper->>ActivationKeyCLI: content_override(activation_key_id, content_label, override)
end
Class diagram for HostRepositoryMixin and ActivationKey CLI after removing content-access-mode-allclassDiagram
class HostRepositoryMixin {
+setup_activation_key(organization, lifecycle_environment, content_view, content, host_collection, override)
}
class ActivationKey {
+product_content(id)
+content_override(activation_key_id, content_label, override)
}
HostRepositoryMixin ..> ActivationKey : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider grepping the codebase for other uses of
content-access-mode-allor related flags to ensure there are no remaining assumptions about that option elsewhere.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider grepping the codebase for other uses of `content-access-mode-all` or related flags to ensure there are no remaining assumptions about that option elsewhere.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
trigger: test-robottelo |
chris1984
approved these changes
Feb 21, 2026
ogajduse
approved these changes
Feb 21, 2026
rmynar
pushed a commit
to rmynar/robottelo
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
--content-access-mode-all option not recognized in Satellite stream-166
SCA (Simple Content Access) is now the default mode, making this option obsolete
Solution
Removed the content-access-mode-all parameter from the ActivationKey.product_content() call
Related Issues
PRT test Cases example
trigger: test-robottelo
pytest: tests/foreman/ui/test_hostcollection.py -k "test_positive_install_errata or test_positive_change_assigned_content or test_positive_install_package"
Summary by Sourcery
Bug Fixes: